react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

fullScreenModal

Open pe-johndpope opened this issue 3 years ago • 4 comments

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

pe-johndpope avatar Mar 22 '22 00:03 pe-johndpope

✅ Deploy Preview for react-navigation-docs ready!

🔨 Explore the source changes: 67800fbaf09d769739557f8df9eb1dd3bf3357d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-docs/deploys/623914b79c48fc000848aa41

😎 Browse the preview: https://deploy-preview-1137--react-navigation-docs.netlify.app

netlify[bot] avatar Mar 22 '22 00:03 netlify[bot]

Hi @pe-johndpope , in native stack navigators, setting the presentation style to "fullScreenModal" would'nt animate the screen from bottom-to-top. Rather, it will use "UIModalPresentationFullScreen" modal style on iOS and will fallback to "modal" on Android. https://reactnavigation.org/docs/native-stack-navigator#presentation

For stack navigators, you can either use "card", "modal" or "transparentModal". https://reactnavigation.org/docs/stack-navigator#presentation

kpose avatar Mar 23 '22 10:03 kpose

I see - my use case is - google "fullscreen modal react" I get this screen - title is appropriately labelled Opening a full-screen modal https://reactnavigation.org/docs/modal/

it doesn't work - it open a modal popup that can be dismissed. the property / fullscreenModal needs to be documented somewhere.....

pe-johndpope avatar Mar 23 '22 22:03 pe-johndpope

Feel free to send a PR to remove the "full screen modal" terminology from this screen. This page is supposed to cover the general usage of modals, regardless of whether it's "UIModalPresentationFullScreen" or not.

fullscreenModal needs to be documented somewhere.....

https://reactnavigation.org/docs/native-stack-navigator/#presentation

satya164 avatar Mar 24 '22 01:03 satya164