react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Argument to `createURL` is now a blank string

Open phatmann opened this issue 4 years ago • 1 comments

If you use use createURL('/'). you will get a triple-slashed prefix in a standalone app; e.g. "myapp:///". You have to use createURL(''), which gives a double-slashed prefix in a standalone app; e.g. "myapp://". A blank string also produces a correct prefix in an Expo-hosted app.

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

phatmann avatar Jul 22 '21 20:07 phatmann

✔️ Deploy Preview for react-navigation-docs ready!

🔨 Explore the source changes: 4782eee46f70ad3799a3bd28cce74a6ac8530d57

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-docs/deploys/60fcac7d8851690007891ae1

😎 Browse the preview: https://deploy-preview-1023--react-navigation-docs.netlify.app

netlify[bot] avatar Jul 22 '21 20:07 netlify[bot]

Thanks for the PR, I believe this is now handled in React Navigation so it'll work fine. AFAIK there is some issue with empty string too but I'm unclear since this API has changed.

Let me know if this is still an issue.

satya164 avatar Oct 31 '22 22:10 satya164