Fixes Issue #108

[BlackJohnny]

[BlackJohnny]

Fixes Issue #108

[BlackJohnny]

Any feedback on this? The issue is happening always, it is not just a side effect of some exotic use case.

[satya164]

Sorry I'm on holidays. Will check soon

[satya164]

Hey! Can you provide a way repro #108? In the drawer code, the drawer opacity is set to 0 until we have the drawer width. It shouldn't be visible until the measurement is complete. So I'm not really sure how the PR addresses the issue.

[BlackJohnny]

Hey! Can you provide a way repro #108? In the drawer code, the drawer opacity is set to 0 until we have the drawer width. It shouldn't be visible until the measurement is complete. So I'm not really sure how the PR addresses the issue.

It is indeed set to 0 however when the layout event is called, the opacity as well as the position are updated, however the order is random and if the opacity goes to 1 before updating the drawer position, we get the flicker.

[alimek]

Just checked this fix and it's not fixing problem of flickering for me:

export default createDrawerNavigator(
  {
    BottomTabNavigation,
  },
  {
    drawerType: 'slide',
    drawerPosition: 'left',
    drawerWidth: Math.round(windowWidth * 0.85),
    contentComponent: DrawerContent,
    edgeWidth: -100,
  },
);

[github-actions[bot]]

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.