react-native-webrtc icon indicating copy to clipboard operation
react-native-webrtc copied to clipboard

ios: add all available camera device types

Open brkkyk opened this issue 1 year ago • 2 comments

Fixes #1560

brkkyk avatar May 02 '24 14:05 brkkyk

Thanks for the patch!

I fear this will break existing apps since there used to be just 2 camera sources.

Can we at least guarantee the first result is the same as before?

saghul avatar May 03 '24 08:05 saghul

Thanks for the patch!

I fear this will break existing apps since there used to be just 2 camera sources.

Can we at least guarantee the first result is the same as before?

I change the order so that it continues to work the same way. It seems like findDeviceForPosition just iterates so it should be fine, what do you think? https://github.com/react-native-webrtc/react-native-webrtc/blob/master/ios/RCTWebRTC/VideoCaptureController.m#L190

brkkyk avatar May 03 '24 11:05 brkkyk

LGTM 🤔 Haven't tested but as long as the original functionality remains, should be good to go.

8BallBomBom avatar May 23 '24 00:05 8BallBomBom

I'll test it after the 124 changes and if all is good we can merge!

saghul avatar May 23 '24 05:05 saghul