react-native-callkit icon indicating copy to clipboard operation
react-native-callkit copied to clipboard

Feature/showing connecting status on answering a call

Open aarkalyk opened this issue 7 years ago • 4 comments

With introducing this PR, on answering a call user will see connecting status and updateConnectionStatus method will need to be called to indicate either start or failure of a call. This will only work if showConnectionState argument is passed to displayIncomingCall, otherwise a call will just get connected immediately as it does in the current version.

Solves the issue #22

aarkalyk avatar Jul 06 '18 13:07 aarkalyk

@ianlin this seems really useful, can you take a look at it?

ckrodrigues avatar Jul 26 '18 19:07 ckrodrigues

@aarkalyk

Hi, Does this introduce a breaking change? Said, what would happen if a user use the older version and does not call updateConnectionStatus ?

zxcpoiu avatar Sep 07 '18 05:09 zxcpoiu

@zxcpoiu Just introduced some changes. There shouldn't be any breaking changes now. @ianlin Can you take a look please?

aarkalyk avatar Dec 15 '18 12:12 aarkalyk

@aarkalyk I tried your PR. It works as below but If I updateConnectionState after connection is established no one can hear each other. Do you have any solutions for this problem?

      NativeModules.RNCallKeep.updateConnectionState(true);
      if (data.callUUID) {
        this.callManager.getSession(data.callUUID).acceptCall();
      } else {
        this.callManager.incomingSession.acceptCall();
      }

zek avatar Apr 08 '19 10:04 zek