CallKit uppercasing call uuid

Open bsiddiqui opened this issue 8 years ago • 2 comments

If I call RNCallKit.endCall('ae708c43-f567-4bcf-8940-fb7013a8aa30'), the end call callback will get data with the uuid uppercased:

{ callUUID: 'AE708C43-F567-4BCF-8940-FB7013A8AA30' }

Is that expected?

Dec 19 '17 22:12 bsiddiqui

It's caused by the use of NSUUID everywhere... For now I ended up converting back to lowercase in the event listeners.

@ianlin would you accept a PR to accept mixed case but always return lowercase UUID's?

Dec 20 '17 03:12 brunsy

Hi @bsiddiqui @brunsy, thanks for pointing this out. Yeah definitely welcome any PR :)

Dec 20 '17 03:12 ianlin