are you planning on supporting react native new architecture any time soon?
@sidhamed did you manage to get it working with new architecture RN >v.0.76 in any way?
unfortunately no
unfortunately no
Thanks for the quick reply! I see the project is pretty unmaintained, but it's the only one right now. Which RN version is the latest supported if you know?
Anything below new architecture.
@sidhamed what issues are you having? Its workign for me in the new build arch
@CaptainJeff new arch supports backward compatibility at some point. I too am able to use this library in new architecture but I doubt this will leverage new architecture support.
Can you describe how did you manage to make it work?
On Fri, Jan 24, 2025, 8:28 AM Ponikar @.***> wrote:
@CaptainJeff https://github.com/CaptainJeff new arch supports backward compatibility at some point. I too am able to use this library in new architecture but I doubt this will leverage new architecture support.
— Reply to this email directly, view it on GitHub https://github.com/react-native-webrtc/react-native-callkeep/issues/822#issuecomment-2611796782, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO34XRV54GZLEQDUVIFSI32MHTS3AVCNFSM6AAAAABTIODQT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRG44TMNZYGI . You are receiving this because you were mentioned.Message ID: @.*** com>
@ponikar I am also interested in this
Hey folks,
I didn't do anything. My react native version is 0.76.5 where the new architecture is enabled by default. I complied my app and ran it in both android and iOS. It is working fine.
@ponikar Are you using the “selfManaged” mode?
everything works fine on ios too, the problem is with android
Hey folks, I didn't do anything. My react native version is
0.76.5where the new architecture is enabled by default. I complied my app and ran it in bothandroidandiOS. It is working fine.
@ponikar What version of react native callkeep are you using?
@KolissnikBogdan ^4.3.16
@KolissnikBogdan
@ponikar Are you using the “selfManaged” mode?
I didn't understand this. I am not expo though.
@ponikar My version is also same like yours
React Native: 0.76.5 Callkeep: ^4.3.16
error: Exception in HostObject::get for prop 'RNCallKeep': com.facebook.react.internal.turbomodule.core.TurboModuleInteropUtils$ParsingException: Unable to parse @ReactMethod annotations from native module: RNCallKeep. Details: Module exports two methods to JavaScript with the same name: "displayIncomingCall
"react-native": "0.76.6" "react-native-callkeep": "4.3.16" # with some PR applied (Looper => handlerThread#825+ remove duplicate methods#816)
everythings seems to work great with new architecture. Until i noticed that didLoadWithEvents never happened on ios. Removed new arch and didLoadWithEvents is back again
try replacing below method in RNCallkeep.m
- (void)sendEventWithNameWrapper:(NSString *)name body:(id)body {
NSLog(@"[RNCallKeep] sendEventWithNameWrapper: %@, hasListeners : %@", name, _hasListeners ? @"YES": @"NO");
if (_hasListeners) {
[self sendEventWithName:name body:body];
} else {
NSDictionary *dictionary = [NSDictionary dictionaryWithObjectsAndKeys:
name, @"name",
body, @"data",
nil
];
if (_delayedEvents == nil) _delayedEvents = [NSMutableArray array];
[_delayedEvents addObject:dictionary];
}
}
Hi. @vishaldaher . You saved my day. Thank you very very much. Be happy !!!
I investigated the problem deeper and found that the reason is a late lazy call to RNCalkeep.init() from React-native Bridge. This problem is inherent to all applications that use swift in AppDelegate and call Objective-C libraries from it.