react-native-callkeep icon indicating copy to clipboard operation
react-native-callkeep copied to clipboard
verified publisher icon react-native-webrtc

remove duplicate definitions of startcall and displayincomingcall as …

Open Irfanwani opened this issue 1 year ago • 12 comments

…react native is thorwing error with the latest version. When upgrading to the latest version of react native (0.76.1), I got this error that RNCallKeep is exporting two methods with same name (got this error for two methods, startCall and displayIncomingCall).

Irfanwani avatar Nov 10 '24 09:11 Irfanwani

It looks like reasonable changes. There is an error if a new architecture is enabled. React-native modules don't support function overloading. And the removed parts seem not to be used anyway in the index.js.

@Irfanwani Could you please remove the commented lines of code? @manuquentin Could you please review? Let's move it to the next release.

mluksha avatar Jan 29 '25 13:01 mluksha

It looks like reasonable changes. There is an error if a new architecture is enabled. React-native modules don't support function overloading. And the removed parts seem not to be used anyway in the index.js.

@Irfanwani Could you please remove the commented lines of code? @manuquentin Could you please review? Let's move it to the next release.

Done @mluksha

Irfanwani avatar Jan 29 '25 13:01 Irfanwani

@mluksha these changes can be merged now. Please proceed

Irfanwani avatar Mar 06 '25 08:03 Irfanwani

@saghul Could you please review this PR?

mluksha avatar Apr 10 '25 14:04 mluksha

@manuquentin any objections to landing this?

saghul avatar Apr 10 '25 18:04 saghul

Hello guys, is this going to be released soon?

devartwa avatar May 12 '25 21:05 devartwa

Can confirm removing duplicate methods displayIncomingCall(String uuid, String number, String callerName) and startCall(String uuid, String number, String callerName) works.

Tested on:

  • expo project with "newArchEnabled": true
  • physical device Galaxy A60 (Android 11)
  • package.json
"expo": "~53.0.17",
"react-native": "0.79.5",
"react-native-callkeep": "^4.3.16",
"@config-plugins/react-native-callkeep": "^11.0.0",

aka #816 looks good to me.

Who we should ping to merge this PR? @manuquentin?

sultanmyrza avatar Jul 18 '25 07:07 sultanmyrza

Hi everyone.

When are you going to merge, please?

jhonbergmann avatar Aug 08 '25 03:08 jhonbergmann

Ping @manuquentin

saghul avatar Aug 08 '25 07:08 saghul

@manuquentin

jhonbergmann avatar Aug 11 '25 22:08 jhonbergmann

Can anyone please merge this PR? It is a small fix hanging from a long time now.

Irfanwani avatar Sep 29 '25 06:09 Irfanwani