react-native-draftjs icon indicating copy to clipboard operation
react-native-draftjs copied to clipboard

Regarding Typescript

Open arunmenon1975 opened this issue 6 years ago • 3 comments

I came across this repo after looking around for React Native editors that both renders as well as allows for editing marked up content. My project may have a web version where i intend to use DraftJS so ideally was looking for a DraftJS compatible library for RN if available. While compatibility may not really be a problem, DraftJS seems to be built well so i was primarily looking for uniformity across the web and native platforms. I did try this package and found that it does work well for my limited usecase on the native platform.

Do you have any plans to make this package Typescript ready? My project uses Typescript so did get the expected errors when i attempted using the library.

I can create a PR if you want since i seem to get the basics going locally by introducing the definition file and the relevant entry in package.json

arunmenon1975 avatar Dec 12 '19 09:12 arunmenon1975

@arunmenon1975 thanks for your interest in this project. You can create a PR with the typescript definition files, we'll take this forward

DaniAkash avatar Dec 13 '19 04:12 DaniAkash

PR at https://github.com/DaniAkash/react-native-draftjs/pull/14

This is very basic. Please edit as necessary.

arunmenon1975 avatar Dec 13 '19 10:12 arunmenon1975

Thanks a lot @arunmenon1975 will ensure to add this on the next release.

DaniAkash avatar Dec 14 '19 13:12 DaniAkash