ios icon indicating copy to clipboard operation
ios copied to clipboard

Crash Caused in Android, with potential solution provided

Open terryatgithub opened this issue 2 years ago • 0 comments

Hi! 👋 Firstly, thanks for your work on this project! 🙂

issue descriptions since this statement https://github.com/react-native-push-notification/ios/blob/904a99fdfa54f25b41c0a5141b4342b8c67b9616/android/app/build.gradle#L79

would cause a crash issue in Android like this: couldn't find DSO to load: libhermes.so

potential solution

would you consider fixing it, as the react-native official recommendation here: https://github.com/facebook/react-native/blob/7ea7d946c643f076c29bcf11b927f7569e3c516f/react.gradle#L18 image

my trial solutions(still under testing)

Today I used patch-package to patch @react-native-community/[email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@react-native-community/push-notification-ios/android/app/build.gradle b/node_modules/@react-native-community/push-notification-ios/android/app/build.gradle
index b857787..89613b1 100644
--- a/node_modules/@react-native-community/push-notification-ios/android/app/build.gradle
+++ b/node_modules/@react-native-community/push-notification-ios/android/app/build.gradle
@@ -1,4 +1,5 @@
 apply plugin: "com.android.application"
+apply plugin: "com.facebook.react"
 
 import com.android.build.OutputFile
 
@@ -76,7 +77,7 @@ project.ext.react = [
     entryFile: "index.js"
 ]
 
-apply from: "../../node_modules/react-native/react.gradle"
+// apply from: "../../node_modules/react-native/react.gradle"
 
 /**
  * Set this to true to create two separate APKs instead of one:

This issue body was partially generated by patch-package.

if any misunderstanding please let me know, thank you so much.

terryatgithub avatar Jan 30 '24 17:01 terryatgithub