playground icon indicating copy to clipboard operation
playground copied to clipboard
verified publisher icon react-native-elements

Added clear functionality to icon in the Input component

Open mhmd21 opened this issue 4 years ago • 5 comments

What kind of change does this PR introduce? I have added clearing functionality to the close icon inside of the input component.

Did you add tests for your changes? It is not needed.

If relevant, did you update the documentation? It is irrelevant.

Summary Attached Ref to the Input component and accessed it inside the icon's onPress function. Issue #70.

Does this PR introduce a breaking change? No it doesn't introduce any breaking changes.

mhmd21 avatar Mar 16 '21 23:03 mhmd21

Deploy preview for rne-playground ready!

Built with commit 5639802eff767ed08959e17e10fb0b2899321f19

https://deploy-preview-79--rne-playground.netlify.app

netlify[bot] avatar Mar 16 '21 23:03 netlify[bot]

This works but seems not the right approach. Can you fix this using the state hook https://react-view.netlify.app/?path=/story/useview--state-hook

I have changed the implementation to use the state hook instead.

mhmd21 avatar Mar 19 '21 23:03 mhmd21

CI is failing, can you pls pull the new changes from the master.

pranshuchittora avatar Mar 20 '21 03:03 pranshuchittora

LGTM

pranshuchittora avatar Mar 26 '21 18:03 pranshuchittora

Thanks

pranshuchittora avatar Mar 26 '21 18:03 pranshuchittora