datetimepicker icon indicating copy to clipboard operation
datetimepicker copied to clipboard

feat: Add TS and Builder Bob

Open Coffeegerm opened this issue 2 years ago • 4 comments

Summary

This PR is aimed at adding Typescript and Builder Bob into the project to smooth up development and deployments in the long run.

closes #773

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • [ ] I have tested this on a device and a simulator
  • [ ] I added the documentation in README.md
  • [ ] I updated the typed files (TS and Flow)
  • [ ] I added a sample use of the API in the example project (example/App.js)
  • [ ] I have added automated tests, either in JS or e2e tests, as applicable

Coffeegerm avatar Jun 26 '23 01:06 Coffeegerm

@Coffeegerm one more thing - it would be amazing, as part of this PR, to have the example app converted to TS as well - there we would see the whole work be used and even out potential glitches. Let me know if that's okay for you, thanks! :)

vonovak avatar Sep 12 '23 08:09 vonovak

@Coffeegerm one more thing - it would be amazing, as part of this PR, to have the example app converted to TS as well - there we would see the whole work be used and even out potential glitches. Let me know if that's okay for you, thanks! :)

No problem, I'll try to get that worked out soon (Going out of town this weekend and will not have time to look, but will soon). I agree that I think it might help identify potential glitches

Coffeegerm avatar Sep 12 '23 15:09 Coffeegerm

Thanks for the great work. I'm looking forward to when the PR will be merged.

megacherry avatar Sep 30 '23 16:09 megacherry

Sorry for the long turn around on this, life's been pretty hectic lately. I'm hoping to be able to focus on this once more as I'd love to have TS be a part of this project.

The remaining issue in the PR seems to that the example project is unable to find the TS definitions we have set, working to resolve this last issue.

Coffeegerm avatar Jan 30 '24 20:01 Coffeegerm