rn-diff-purge icon indicating copy to clipboard operation
rn-diff-purge copied to clipboard

0.61.1 is incorrectly using react 16.8.1

Open matt-oakes opened this issue 6 years ago • 5 comments

You can see this in the diff here:

https://react-native-community.github.io/upgrade-helper/?from=0.61.0&to=0.61.1

There are no commits between RN 0.61.0 and 0.61.1 which downgrade React. This version is also below the one used in RN 0.60, so I think it must be a mistake.

matt-oakes avatar Sep 25 '19 10:09 matt-oakes

👍

codler avatar Sep 25 '19 10:09 codler

The same issue can be seen for 0.61.2:

https://react-native-community.github.io/upgrade-helper/?from=0.61.1&to=0.61.2

Several dependencies appear to have been downgraded. This is not the case, as can easily be checked by npx react-native init rn0612 --version 0.61.2.

Any updates on this?

friederbluemle avatar Oct 02 '19 20:10 friederbluemle

I want to trust rn-diff-purge but that caught in error three times.

Bardiamist avatar Oct 03 '19 05:10 Bardiamist

Fixed. Unfortunately this comes from the new react native cli, but using the old cli produces correct diffs. We are trying to fix the problem that causes this. Until that is fixed, we try to generate the diffs with it initially, and if it's wrong, we regenerate them using the old cli. Sorry for the inconvenience.

pvinis avatar Oct 03 '19 07:10 pvinis

Interestingly, I rerun the script using npx for the new cli, and it worked this time. 🤔

pvinis avatar Oct 03 '19 07:10 pvinis