fix: add PROJECT_ROOT variable to pass launchPackager
Summary:
These days I working on a monorepo project, I try to prevent using "nohoise" option
There is a problem in react-native when it trying to run cli.js in launchPackager.bat file, react-native go two folders up then run cli.js
If you have a monorepo project folder tree is like this:
- project
- packages
- appA
- appB
- libA
- node_modules
- react-native
- metro
- ...
In this case, it should move to PROJECT_ROOT and then run cli.js
I fix the launchPackager.bat too, If this pull request is accepted, I will create a pull request for react-native too.
Test Plan:
I tested it with react-native change locally, this change has no effect on any project because I add a variable for further use.
any luck with this PR please? I am also working with a mono repo whos having the same problem:(
sorry @charkcl, this weekend I have a tough and big exam, I will try to complete this pull request soon
@thymikee could you please take a look at this pr?
@thymikee sorry for linter, this time I fix linter this line by running following command
> npm run linter --fix
@thymikee Is it possible that this request will be merged?
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.