cli icon indicating copy to clipboard operation
cli copied to clipboard

profile-hermes command haven't consider android's applicationIdSuffix config

Open glacjay opened this issue 4 years ago • 1 comments

Environment

System:
    OS: macOS 11.4
    CPU: (4) x64 Intel(R) Core(TM) i5-4258U CPU @ 2.40GHz
    Memory: 68.37 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.22.1 - /var/folders/hc/45n2bvns607682x5dkq6xx5r0000gn/T/yarn--1625025796252-0.39218846538025054/node
    Yarn: 1.22.10 - /var/folders/hc/45n2bvns607682x5dkq6xx5r0000gn/T/yarn--1625025796252-0.39218846538025054/yarn
    npm: 6.14.12 - /usr/local/bin/npm
    Watchman: 2021.06.07.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK: Not Found
  IDEs:
    Android Studio: 3.2 AI-181.5540.7.32.5056338
    Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
  Languages:
    Java: 15.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.64.1 => 0.64.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Description

$ yarn react-native profile-hermes --verbose
yarn run v1.22.10
$ /Users/wagons/work/WagonsFrontapp-feature/node_modules/.bin/react-native profile-hermes --verbose
info Downloading a Hermes Sampling Profiler from your Android device...
info No filename is provided, pulling latest file
run-as: package not debuggable: com.wagons.app
error There is no file in the cache/ directory. Did you record a profile from the developer menu?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

According to our build.gradle, we have applicationIdSuffix set as .test to the debug variant, so the actual package name should be com.wagons.app.test. That's why it can't find the .cpuprofile file.

Reproducible Demo

glacjay avatar Jun 30 '21 04:06 glacjay

Same issue any update on this

FadiAboMsalam avatar Feb 23 '22 10:02 FadiAboMsalam

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Nov 26 '22 03:11 github-actions[bot]

I am using react native 0.68 I have the same issue. When running the profile-hermes it's not consider the applicationIdSuffix

rilfi avatar Jul 10 '23 09:07 rilfi