feat: first implementation of Compound Component technique

Open CloudPower97 opened this issue 6 years ago • 4 comments

Description

This P.R addresses #902 . As of now, for demonstration purposes, I've just modified Tabs and Tab component. However, before a final decision is made for this, I'd like to push at lease a couple more of examples.

Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?

Not necessary ATM .

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have not generated a new package version. (the maintainers will handle that)

Oct 01 '19 23:10 CloudPower97

@alextrastero Sure, I'm going to modify a specific component for each commit. Is this okay for you? :relaxed:

Oct 03 '19 18:10 CloudPower97

@CloudPower97 thanks :)

This is quite a big change, some could deem unnecessary so if there's a commit by commit short story on why and what is happening it's easier to push forward.

Could this be done without it being a breaking change?

Oct 09 '19 07:10 alextrastero

@alextrastero Unfortunately I think there is no way to make it not a breaking change... But I'm sure that the flexibility that we are going to have is going to make everyone happy :nerd_face:

Oct 09 '19 17:10 CloudPower97

Ok no worries, create a new PR please with only the required changes and divided commit by commit so we can review :) thx!

Oct 10 '19 11:10 alextrastero