web icon indicating copy to clipboard operation
web copied to clipboard

State updates in useLocalStorageValue are not queued like useState is.

Open rstepinski opened this issue 2 years ago • 0 comments

Prior Issues

none

What is the current behavior?

Using multiple state updates from useLocalStorageValue, be it in different components or sequentially in the same component, are not queued. The last state update receives the initial state and not the state already altered by previous updates.

Steps to Reproduce

Consider the following code:

const { set } = useLocalStorageValue<number, number, true>('test', { defaultValue: 0 });

set((prev) => {
  console.log(prev); // Expect 0
  return prev + 1;
});
set((prev) => {
  console.log(prev); // Expect 1
  return prev + 1;
});
set((prev) => {
  console.log(prev); // Expect 2
  return prev + 1;
});

All set calls will receive 0.

What is the expected behavior?

State updates should be queued to allow for sequential state updates. If this is not possible, it should be clearly mentioned in the documentation that the expected behavior differs from what we're used to with useState.

Environment Details

  • @react-hookz/web version: 24.0.2
  • react version: 18.2.0
  • react-dom version: 18.2.0
  • typescript version: 5.2.2
  • OS: Ubuntu
  • Browser: Chrome
  • Did this work in previous versions? didn't use previous versions

rstepinski avatar Jan 30 '24 12:01 rstepinski