file-selector icon indicating copy to clipboard operation
file-selector copied to clipboard

[ENHANCEMENT] Is possible that you share this component for Denojs?

Open sonickseven opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. I'm starting with Denojs and your library is very powerful and simple, but I can't use that directly in Denojs

Describe the solution you'd like Will very good if you share you code for anywhere in version ES module (import/export), I currently use your library with [unpkg](https://unpkg.com/[email protected]/dist/bundles/file-selector.umd.min.js but isn't the same standar :sob:

Describe alternatives you've considered You can share in Skypack or denoland for example and it is very simple. the deno community will very grateful with you

sonickseven avatar Apr 05 '24 04:04 sonickseven

@sonickseven that is a great suggestion, but I'm not very familiar with denojs or skypack. If you're familiar with the tooling, please feel free to create a PR.

Maybe if we provide ESM support that will make it work with denojs.

rolandjitsu avatar Oct 04 '24 20:10 rolandjitsu

@sonickseven using the following:

import {fromEvent} from "npm:file-selector";
console.log(fromEvent);

And running it:

➜  deno run test.ts

Results in:

[Function: fromEvent]

Which means that denojs can import our package. So I'm unsure what issue you're experiencing. I'll leave this open for a bit longer so you can provide more details if you'd like.

rolandjitsu avatar Nov 02 '24 11:11 rolandjitsu

@rolandjitsu Deno only recently introduced backwards compatibility with Node.js and NPM, so at the time this issue was logged it did not work. I think this can safely be closed now that the package is fully ESM and Deno has added support for NPM packages.

jonkoops avatar Nov 04 '24 09:11 jonkoops