react-dates icon indicating copy to clipboard operation
react-dates copied to clipboard

Use new declarative Storybook configs

Open wuweiweiwu opened this issue 5 years ago • 4 comments

noticed that the title of the storybook is the default "storybook" so i decided to update the configurations! as https://www.npmjs.com/package/@storybook/addon-options is deprecated

blog post here: https://medium.com/storybookjs/declarative-storybook-configuration-49912f77b78

Changes:

  • created main.js preview.js manager.js for storybook and storybook-css
  • updated storybook-css to use full control mode (same webpack config as storybook)

Testing:

  • run yarn storybook[:css] and yarn gh-pages:build

Follow ups:

  • usage of withInfo needs to be updated. the current way is deprecated
  • configs between storybook and storybook-css is almost identical. webpack.config.js main.js and parts of preview.js can be shared

wuweiweiwu avatar Mar 24 '20 07:03 wuweiweiwu

This still seems worth including at some point; we just haven't gotten to it. I'd prefer to leave it open, if that's alright.

ljharb avatar Jun 17 '21 21:06 ljharb

No problem! I can update to the latest storybook versions as well

wuweiweiwu avatar Jun 24 '21 21:06 wuweiweiwu

Thanks, that’d be great!

ljharb avatar Jun 24 '21 22:06 ljharb

Codecov Report

Merging #1952 (06b62de) into master (3ddb7b5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1952   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          57       57           
  Lines        2285     2285           
  Branches      635      635           
=======================================
  Hits         1818     1818           
  Misses        274      274           
  Partials      193      193           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ddb7b5...06b62de. Read the comment docs.

codecov[bot] avatar Nov 30 '21 00:11 codecov[bot]