trigger icon indicating copy to clipboard operation
trigger copied to clipboard

Add close popup when click iframe for `click` trigger

Open stephen-james opened this issue 7 years ago • 5 comments

Using Trigger with contextMenu supports closing on window blur, in order to cover when a user clicks/taps on an iframe, but when we use click as a trigger, this was previously not supported.

This fix modifies the handler to support both click and contextMenu as valid triggers.

  • simulates document click on window blur for both click and contextMenu triggers
  • contextMenuOutsideHandler1 renamed to contextMenuScrollOutsideHandler to be more descriptive about what case it is handling.
  • contextMenuOutsideHandler2 renamed to clickBlurOutsideHandler since it is the handler for click and contextMenu triggers (similar to clickOutsideHandler)

stephen-james avatar Aug 13 '18 10:08 stephen-james

Coverage Status

Coverage remained the same at 76.389% when pulling bcdf1ee01340a0904b31ed7290ac4b0348d1f1b7 on stephen-james:fix/close-popup-on-iframe-click into a619be207a78b5372893cc4f7d379f0f51caa637 on react-component:master.

coveralls avatar Aug 13 '18 10:08 coveralls

I also encountered this issue, could this PR get merged?

evanyeung92 avatar May 12 '20 14:05 evanyeung92

how can we trigger this in an iframe?

wonjunkang avatar Oct 05 '20 20:10 wonjunkang

@zombieJ Can you please check on this. I have the same issue with iframe

nmaddp1995 avatar Nov 24 '20 05:11 nmaddp1995

@zombieJ @afc163 the same, what's going on with this issue

gy134340 avatar Apr 15 '22 03:04 gy134340