tabs icon indicating copy to clipboard operation
tabs copied to clipboard

ScrollableInkBar position is incorrect

Open hon2a opened this issue 7 years ago • 0 comments

I'm using Tabs from Ant Design and apparently they use the ScrollableInkBar component from this lib. As of few days ago, the ink bar has stopped showing for our vertical tabs and upon investigation I found that it's being positioned way above where it should be (and subsequently hidden as overflow). In other words:

Expected

Ink bar shows over the selected vertical tab.

Actual

Ink bar is positioned somewhere else completely. Might be that its position from the top edge of the viewport is what it should be from the top edge of the tabs container, but that's just a hunch. In any case, the ink bar position changes appropriately (relative) when tab selection changes, but the base offset is wrong.

Additional Notes

Further investigation yielded the fact that there was a corresponding release here ~3 days ago. The version from before that release (9.4.1) works correctly, the latest version (9.4.3) does not. There was only one relevant commit in that release, so that's what must've broken the functionality.

hon2a avatar Sep 16 '18 13:09 hon2a