slider icon indicating copy to clipboard operation
slider copied to clipboard

feat: add distanceBetweenHandles

Open doong-jo opened this issue 5 years ago • 7 comments

This solves https://github.com/react-component/slider/issues/402

Added the ability to keep the distance between the handles.

Thanks.

doong-jo avatar Aug 20 '20 18:08 doong-jo

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/8jcy9x8ja
✅ Preview: https://slider-git-distance-range.react-component.vercel.app

vercel[bot] avatar Nov 06 '20 16:11 vercel[bot]

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.62%. Comparing base (c790ca8) to head (4255433).

:exclamation: Current head 4255433 differs from pull request most recent head 6eb9ef4. Consider uploading reports for the commit 6eb9ef4 to get more accurate results

Files Patch % Lines
src/Range.tsx 27.27% 8 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##            master     #675       +/-   ##
============================================
- Coverage   100.00%   87.62%   -12.38%     
============================================
  Files           13       11        -2     
  Lines          558      719      +161     
  Branches       169      186       +17     
============================================
+ Hits           558      630       +72     
- Misses           0       89       +89     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 06 '20 16:11 codecov[bot]

Rebase please.

yoyo837 avatar Apr 15 '23 15:04 yoyo837

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 6:28am

vercel[bot] avatar Feb 24 '24 06:02 vercel[bot]

@afc163 Would you reivew this PR?

doong-jo avatar Feb 24 '24 06:02 doong-jo

Just add an example?

yoyo837 avatar Feb 24 '24 07:02 yoyo837

Oh, it's changed too much from when I first wrote it. I'll change it to draft state and work on it later.

doong-jo avatar Feb 24 '24 13:02 doong-jo