Critical Bug Fix: Keyboard listeners for range slider
In the range slider , the currentHandle parameter is not determined correctly when using the keyboard to move the handles. As a result, when using range-slider by keyboard (e.g. arrow keys) the whole component crashes. I made a quick fix to use the recent handle if the current handle is not found.
Codecov Report
Merging #510 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 10 10
Lines 463 463
Branches 120 121 +1
=======================================
Hits 386 386
Misses 77 77
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/Range.jsx | 60.13% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0cdc5c4...4392fe8. Read the comment docs.
When this fix is going to be merged?
It will still crash.
state.handle => state.handle || state.recent
But I found a new problem.
I think the original logic should be fixed.
Rebase please.