slider icon indicating copy to clipboard operation
slider copied to clipboard

Critical Bug Fix: Keyboard listeners for range slider

Open M-Izadmehr opened this issue 7 years ago • 5 comments

In the range slider , the currentHandle parameter is not determined correctly when using the keyboard to move the handles. As a result, when using range-slider by keyboard (e.g. arrow keys) the whole component crashes. I made a quick fix to use the recent handle if the current handle is not found.

M-Izadmehr avatar Dec 27 '18 08:12 M-Izadmehr

Codecov Report

Merging #510 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          10       10           
  Lines         463      463           
  Branches      120      121    +1     
=======================================
  Hits          386      386           
  Misses         77       77
Impacted Files Coverage Δ
src/Range.jsx 60.13% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cdc5c4...4392fe8. Read the comment docs.

codecov[bot] avatar Dec 27 '18 08:12 codecov[bot]

When this fix is going to be merged?

GiselaMD avatar Feb 20 '19 13:02 GiselaMD

image It will still crash. image state.handle => state.handle || state.recent

ztplz avatar Feb 21 '19 06:02 ztplz

But I found a new problem. untitled7 I think the original logic should be fixed.

ztplz avatar Feb 21 '19 06:02 ztplz

Rebase please.

yoyo837 avatar Apr 15 '23 15:04 yoyo837