fix: tab to select an active option

[nathanlao]

This is a

keyboard accessibility

Background

When the dropdown is open and an option is active, pressing Tab should select the currently active option. Fix https://github.com/ant-design/ant-design/issues/26876

Solution

• Handle the case for key TAB in onSelect event
• Added test case

Summary by CodeRabbit

• 新特性
  • 增强了OptionList组件的键盘导航功能，支持使用Tab和Enter键选择选项。
• 测试
  • 添加了新的测试用例，验证Tab键选择活动选项的行为。

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2024 9:15am

[coderabbitai[bot]]

Walkthrough

在此拉取请求中，src/OptionList.tsx 组件进行了更新，以增强键盘导航功能。onKeyDown 方法现在处理 KeyCode.TAB 键，允许用户使用 Tab 和 Enter 键选择选项。同时，测试文件 tests/OptionList.test.tsx 中增加了一个新测试用例，以验证在按下 Tab 键时是否能够正确选择活动选项。整体结构和逻辑保持不变，未对核心功能或控制流进行修改。

Changes

文件	更改摘要
src/OptionList.tsx	更新 onKeyDown 方法以处理 KeyCode.TAB 键，注释已修改为“Select (Tab / Enter)”。
tests/OptionList.test.tsx	添加新测试用例“should tab key select an active option”，验证 Tab 键的选择功能。

Assessment against linked issues

Objective	Addressed	Explanation
Tabbing to select active option in <Select> (#26876)	✅

Possibly related PRs

• #1077: 此 PR 修改了 src/OptionList.tsx 中的 OptionList 组件，可能与主 PR 的功能和可访问性特性相关。

Poem

在选项中跳跃，兔子欢快，
Tab 键轻触，选择无碍。
选项如花，随风摇摆，
兔子欢呼，乐在其中，
让我们一起，享受这场盛会！ 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.24%. Comparing base (601a209) to head (e18d975). Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          39       39           
  Lines        1482     1483    +1     
  Branches      418      447   +29     
=======================================
+ Hits         1456     1457    +1     
  Misses         26       26           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[override-apps]

+1

[zuyetawarmatik]

This causes a regression in behavior when we update Antd to 5.22.x. If the Select's input is focused, pressing Tab will remove the previous entry, which is not user-friendly.