pagination icon indicating copy to clipboard operation
pagination copied to clipboard

Pagination's pageSizeOptions Select component's showSearch props handled dynamically.

Open prakashks20 opened this issue 2 years ago • 8 comments

Ant Design Pagination enhanced feature added in https://github.com/ant-design/ant-design/pull/46757 depends this PR changes

prakashks20 avatar Jan 02 '24 18:01 prakashks20

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 5:20pm

vercel[bot] avatar Jan 02 '24 18:01 vercel[bot]

@MadCcc Waiting for this PR approval

prakashks20 avatar Jan 09 '24 04:01 prakashks20

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (998957f) 98.70% compared to head (8efdfaa) 98.71%. Report is 1 commits behind head on master.

:exclamation: Current head 8efdfaa differs from pull request most recent head 0bcabf1. Consider uploading reports for the commit 0bcabf1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files           3        3           
  Lines         310      311    +1     
  Branches      137      138    +1     
=======================================
+ Hits          306      307    +1     
  Misses          4        4           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 09 '24 05:01 codecov[bot]

@MadCcc I Waiting for PR approval long time. Can you check this PR code ASAP?

prakashks20 avatar Jan 09 '24 17:01 prakashks20

@MadCcc How to update the testing snapshot in the rc-pagination repository? Please help it to resolve the above coverage check failure.

prakashks20 avatar Jan 10 '24 03:01 prakashks20

Add some test case to fix coverage test failed.

yoyo837 avatar Jan 10 '24 03:01 yoyo837

Combine all props related with sizeChanger together would be better, and could reuse props of Select.

pageSizeChanger: {
  onChange,
  options,
  showSearch,
}

MadCcc avatar Jan 10 '24 03:01 MadCcc

@prakashks20 how it's going? Do you need any help, because I need this fix as well?

Enigama avatar Mar 15 '24 11:03 Enigama

https://github.com/react-component/pagination/pull/554#issuecomment-1884129690

afc163 avatar Jul 23 '24 02:07 afc163

Move to #597

yoyo837 avatar Jul 25 '24 03:07 yoyo837

Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes

These review changes have been addressed in the pull request below. So, please close this pull request.

https://github.com/react-component/pagination/pull/597

prakashks20 avatar Jul 25 '24 03:07 prakashks20

These review changes have been addressed in the pull request below. So, please close this pull request.

#597

These fix changes are completed and pull request has been created

prakashks20 avatar Jul 25 '24 03:07 prakashks20

Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes

These review changes have been addressed in the pull request below. So, please close this pull request.

#597

@MadCcc @afc163 @Enigama FYI

prakashks20 avatar Jul 25 '24 03:07 prakashks20