mentions icon indicating copy to clipboard operation
mentions copied to clipboard

keyUp/keyDown event dispatch and textarea style support

Open dbFlower opened this issue 6 years ago • 14 comments

feat: dispatch keyUp/keyDown event feat: support textAreaStyle

dbFlower avatar May 29 '19 07:05 dbFlower

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-mentions-git-fork-dbflower-feature-keyboard-events-dispatch.react-component.now.sh

vercel[bot] avatar May 29 '19 07:05 vercel[bot]

master 上的 test 一样跑不过去,吐血。

dbFlower avatar May 29 '19 07:05 dbFlower

@zombieJ master上的ci一样跑不过去,而且本次提交不影响ci测试的部分

dbFlower avatar Jun 12 '19 07:06 dbFlower

能举个例子什么情况需要这几个属性?

zombieJ avatar Jun 12 '19 10:06 zombieJ

keyUp/keyDown -> 监听回车发送。 textAreaStyle -> 文本域自动高度设置(参考antd input内的 textarea)

dbFlower avatar Jun 12 '19 10:06 dbFlower

拆成 2 个吧,先把 onKeyDownonKeyUp 弄了。

zombieJ avatar Jun 12 '19 10:06 zombieJ

传递 measuring 的目的是什么?

zombieJ avatar Jun 12 '19 10:06 zombieJ

传递 measuring 的目的是什么?

  handleKeyDown: HoneyMentionsProps['onKeyDown'] = (e, measuring) => {
    if (measuring) {
      return;
    }
    // do something
 }

dbFlower avatar Jun 12 '19 10:06 dbFlower

拆成 2 个吧,先把 onKeyDownonKeyUp 弄了。

我先提交一个新的commit把textAreaStyle拔掉咯?

dbFlower avatar Jun 12 '19 10:06 dbFlower

感觉需要包一下 (event, { measuring }),免得以后变成 (event, measuring, someState2, someState3, ...)

zombieJ avatar Jun 12 '19 10:06 zombieJ

关于textAreaStyle这个,其实不止缺少这一个,在实际使用中还缺少点其他的,我会新开一个issue讨论。 我现在先提交一个新的事件派发处理了

dbFlower avatar Jun 12 '19 10:06 dbFlower

@zombieJ committed

dbFlower avatar Jun 12 '19 10:06 dbFlower

还需要加对应的测试用例

zombieJ avatar Jun 12 '19 12:06 zombieJ

  • Please add test case.
  • Resolve conflicts

afc163 avatar Dec 21 '20 11:12 afc163