input-number icon indicating copy to clipboard operation
input-number copied to clipboard

fix: update value on formatter change fixes:ant-design/ant-design#31431

Open g7i opened this issue 4 years ago • 6 comments

fixed: ant-design/ant-design#31431

g7i avatar Aug 01 '21 13:08 g7i

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/6zp8x4CdnhZwQgGkB5jDF1rr52Lg
✅ Preview: https://input-number-git-fork-g7i-fix-formatter-react-component.vercel.app

vercel[bot] avatar Aug 01 '21 13:08 vercel[bot]

@g7i Hello! I have faced the same issue as described here #347 and a related one is here https://github.com/ant-design/ant-design/issues/31431

Is it possible to merge this PR?

IgorStetsiuk avatar Oct 18 '21 18:10 IgorStetsiuk

Could you add a test case?

afc163 avatar Oct 19 '21 03:10 afc163

Could you add a test case?

Sure, will add a test case for it

g7i avatar Oct 19 '21 04:10 g7i

@afc163 I have added the test case.

g7i avatar Oct 19 '21 13:10 g7i

Codecov Report

Merging #347 (57ffeef) into master (c4ae6f8) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   97.59%   97.67%   +0.07%     
==========================================
  Files           8        9       +1     
  Lines         416      430      +14     
  Branches      114      115       +1     
==========================================
+ Hits          406      420      +14     
  Misses         10       10              
Impacted Files Coverage Δ
src/InputNumber.tsx 98.33% <100.00%> (+0.04%) :arrow_up:
src/hooks/useFrame.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4ae6f8...57ffeef. Read the comment docs.

codecov[bot] avatar Nov 18 '21 10:11 codecov[bot]

@zombieJ I could have rebased it myself if you would have posted a comment for the same. Anyway, thanks for finally resolving the issue. Its been stuck for too long.

g7i avatar Oct 13 '23 10:10 g7i