fix: conditional render makes wrapper lose focus

Open jrr997 opened this issue 3 years ago • 5 comments

This is the referred issue

Mar 01 '22 16:03 jrr997

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/46heebJ4tPQRewxVP8eShrHru8bV
✅ Preview: https://dialog-git-fork-jrr997-master-react-component.vercel.app

Mar 01 '22 16:03 vercel[bot]

Would you mind to add a test case?

Mar 02 '22 02:03 afc163

Would you mind to add a test case?

I will add it latter.

Mar 02 '22 02:03 jrr997

finished test case

Mar 04 '22 09:03 jrr997

Codecov Report

Merging #283 (da96f7a) into master (65f1f8c) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   98.12%   98.19%   +0.06%     
==========================================
  Files           6        6              
  Lines         160      166       +6     
  Branches       47       47              
==========================================
+ Hits          157      163       +6     
  Misses          2        2              
  Partials        1        1

Impacted Files	Coverage Δ
src/Dialog/index.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65f1f8c...da96f7a. Read the comment docs.

Mar 04 '22 11:03 codecov[bot]

https://github.com/ant-design/ant-design/issues/33917#issuecomment-1295782475

Oct 29 '22 09:10 afc163