dialog icon indicating copy to clipboard operation
dialog copied to clipboard

fix: Fix uuid during testing

Open hedrall opened this issue 3 years ago • 2 comments

How about fixing the UUID by referring to NODE_ENV?

In my test environment, import rc-dialog only once (via antd), so the snapshot test will show the difference.

スクリーンショット 2022-02-25 6 51 20

hedrall avatar Feb 24 '22 22:02 hedrall

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/82aAcdjVNct2a4Kk24JeftJnGx2b
✅ Preview: https://dialog-git-fork-hedrall-feature-fix-uuid-ff71f9-react-component.vercel.app

vercel[bot] avatar Feb 24 '22 22:02 vercel[bot]

Codecov Report

Merging #282 (c9eec35) into master (65f1f8c) will decrease coverage by 1.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   98.12%   96.91%   -1.22%     
==========================================
  Files           6        6              
  Lines         160      162       +2     
  Branches       47       48       +1     
==========================================
  Hits          157      157              
- Misses          2        4       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/util.ts 92.85% <100.00%> (-7.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65f1f8c...c9eec35. Read the comment docs.

codecov[bot] avatar Feb 25 '22 02:02 codecov[bot]