animate icon indicating copy to clipboard operation
animate copied to clipboard

fix: shoud determine whether the component is react.Fragment

Open zaleGZL opened this issue 5 years ago • 5 comments

React.Fragment has only one key property, we need to add judgement, we cannot pass other properties to React.Fragment.

example: image

zaleGZL avatar Feb 17 '20 09:02 zaleGZL

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

vercel[bot] avatar Feb 17 '20 09:02 vercel[bot]

Coverage Status

Coverage increased (+0.04%) to 82.816% when pulling af54caa04aa649f813f3ddda7d44502b2e141b46 on zaleGZL:fix_fragment_error into a1385aa0493b3517cee3d7e441949bdd116a3645 on react-component:master.

coveralls avatar Feb 17 '20 09:02 coveralls

@afc163 Can you look at this pr?

zaleGZL avatar Feb 17 '20 09:02 zaleGZL

Could you please fix ci?

afc163 avatar Feb 22 '20 06:02 afc163

This fix just make Animate not throw error but also make Animation not work with React.Fragment. Could you provide more info like reproduce that why you need use Fragment with rc-animatie?

zombieJ avatar Feb 22 '20 11:02 zombieJ