cortex icon indicating copy to clipboard operation
cortex copied to clipboard
verified publisher icon rdevon

inconsistent parameters?

Open shizhan1992 opened this issue 5 years ago • 0 comments

https://github.com/rdevon/cortex/blob/2837b220f9fb73279df3815bb18b274106412c08/cortex/built_ins/models/mine.py#L94 Hi, thank you for this great repository. I am wondering if line 94 and line 111 are correct? shouldn't it be self.mine.routine(generated, generated, Z, Z_P)? because the routine accepts arguments in the order of "X_real, X_fake, Z_real, Z_fake".

Besides, line 123 "self.mine.visualize(generated, generated, Z, Z_N, targets)" seems correct.

shizhan1992 avatar Feb 27 '20 23:02 shizhan1992