rd235
chore(macOS): fix compile and running error for macOS
macOS do not support SCTP protocol and SOCK_CLOEXEC flag. So I have changed SCTP to TCP protocol and set SOCK_CLOEXEC to 0 for macOS.
On Sun, Oct 14, 2018 at 12:29:11PM -0700, sharpbai wrote:
macOS do not support SCTP protocol and SOCK_CLOEXEC flag. So I have changed SCTP to TCP protocol and set SOCK_CLOEXEC to 0 for macOS.
It is not SCTP as it is on AF_LOCAL (a.k.a. AF_UNIX).
The correct semantics needed for the communication channel with the slirp thread is SOCK_SEQPACKET otherwise the readv instruction in line 485 of libslirp.c can read several requests in a single read (if the buffer is large enough to fit all). We need the "packet boundaries".
For what concerns SOCK_CLOEXEC, even if MacOS does not support it, the socketpair cannot be inherited by forked processes. It is useless and potentially disrupting. As a workaround fcntl(2) can be used to set FD_CLOEXEC by the request named F_SETFD. It is just a workaround as in a multithreaded environment the creation of the socketpair and the flags setting must be done atomically.
If you have thoroughly tested your patch for MacOS (it would mean that it works because of the specific implementation of SOCK_STREAM) I can consider to add a patch for MacOS only. I have not any proprietary operating system so I cannot test your patch so you'd have to swear and take any responsability for MacOS ;-)
In no case I'll change SOCK_SEQPACKET to SOCK_STREAM for GNU-Linux. I'll add a fcntl to set FD_CLOEXEC for Macs, too.
Happy hacking renzo
I have changed SOCK_STREAM to SOCK_DGRAM to ensure packet boundary. The socket buffer have been changed in order to avoid packet loss for udp socketpairs. The SOCK_CLOEXEC flag have also been set using fcntl.