route-parser icon indicating copy to clipboard operation
route-parser copied to clipboard

Escape asterisks and parantheses in routes

Open iglrob opened this issue 7 years ago • 1 comments

This lib is truly awesome! After using it for a while I came across a certain problem: Asterisks and parentheses are valid components of an URL but reserved in this lib. (Refer to this IETF-spec)

If it was for illegal characters in the URL I would expect the user of the lib to escape them. But since those are valid characters I think the lib should take care of escaping them.

iglrob avatar Apr 09 '18 15:04 iglrob

I checked the errors in Travis.They are not due to changes made in the pullrequest but in some sub-dependency of prebuilt PhantomJS.

iglrob avatar Apr 09 '18 15:04 iglrob