react-trello icon indicating copy to clipboard operation
react-trello copied to clipboard

Cannot drop a card near the bottom of a lane

Open sylvain-hamel opened this issue 6 years ago • 7 comments

Describe the bug When dropping a card, it has to be dropped very close the the previous card, otherwise the drop is cancelled

To Reproduce See gif

Desktop (please complete the following information):

  • OS: win 10
  • Browser chrome
  • Version 72 drag1

sylvain-hamel avatar Mar 18 '19 14:03 sylvain-hamel

Here is minor fix - https://github.com/rcdexta/react-trello/pull/265

But I think the best way to show placeholder like it trello do. And place card into bottom placeholder even it dropped outside of the lane bottom.

pWpsRqfTDo

Than this is a new feature

dapi avatar Jun 25 '19 16:06 dapi

@dapi first of all, thanks for this project. If I understand it correctly, Than this is a new feature, do you mean dropping the card into the bottom even outside the lane bottom is still not supported? If yes, is it actively worked on? If not, I can check the source and will try to work on it. Thanks!

iamriel avatar Jan 03 '20 05:01 iamriel

Right now, I did a dirty fix to achieve this through css:

.react-trello-lane {
  .smooth-dnd-container {
    min-height: calc(100vh - 270px);
  }
}

iamriel avatar Jan 05 '20 11:01 iamriel

@iamriel Where did you place this code?

bmoffitt1990 avatar Jan 30 '20 19:01 bmoffitt1990

@bmoffitt1990 Sorry for the late reply, I just placed it in my css file, outside of this project. You can place it anywhere as long as it points to the correct class .react-trello-lane .smooth-dnd-container.

iamriel avatar Feb 26 '20 03:02 iamriel

+1 to this. Nice to have a quick fix but would be nice to have this by default Thank you for the css fix, I found the same but my css code was uglier (padding-bottom: 300px) haha

to give more info: lZcEdRNv6o

lveillard avatar Jul 08 '20 10:07 lveillard

And with the fix: 4wCfhnbDHJ

I think this is actually both a fix and a feature: A fix would be to apply this css code

A feature would be to do it like trello does, with the placeholder shadow and even outside of the lane

lveillard avatar Jul 08 '20 11:07 lveillard