Ricardo Buring

Results 52 comments of Ricardo Buring

I addressed the style comments and updated to 4.5. I agree the comments in `main.gd` can be improved, and that the demo should have an export preset with the polyfills...

Some/most of the arithmetic/setter methods (`gr_ore_poly_add` for example) are not getting called in the ring tests. I'm not sure what I did wrong since I did put them in the...

I reorganized the code to collect the wrapper functions in one file, and applied all the other suggestions above. I removed all the methods with `scalar` in the name and...

I updated the context and constructor to include an index of a generator of the base ring, and (hopefully) clarified the documentation. I think the restriction to generators of the...

Another question: How should the `q` parameter for q-shifts or q-derivations be handled? The current `gr_ctx_init_gr_ore_poly` and the struct `_gr_ore_poly_ctx_struct` do not refer to it. Can this be left for...

Thanks for the extensive feedback @mezzarobba, I think it looks better now. What do you think about using the name `ore_algebra_t` for the enum? With values `ORE_ALGEBRA_STANDARD_DERIVATIVE` and `ORE_ALGEBRA_EULER_DERIVATIVE` for...

Personally I would like to be able to use this functionality to calculate large [expressions](https://seaofpoisson.github.io/poisson_structures/generic_poisson_structure_2d_deformation_from_5_wheel_graph_cohomology_class.html) like in my Ph.D. thesis (but faster): (-10*u_y^3*u_xx*u_yy*u_xxx + 20*u_x*u_y^2*u_xy*u_yy*u_xxx - 10*u_x^2*u_y*u_yy^2*u_xxx + 20*u_y^3*u_xx*u_xy*u_xxy -...

Compiling with `CFLAGS='-fstrict-aliasing -Wstrict-aliasing=1 -O2'` produces possibly relevant warnings. Here's a selection: ``` /home/rburing/src/flint-gcc15/src/nmod_poly/hgcd.c: In function '_nmod_poly_hgcd': /home/rburing/src/flint-gcc15/src/nmod_poly/hgcd.c:30:5: warning: dereferencing type-punned pointer might break strict-aliasing rules [-Wstrict-aliasing] 30 | GR_MUST_SUCCEED(_gr_poly_hgcd(NULL,...

This is a documentation issue. The return values of `PhysicsDirectSpaceState3D.intersect_shape` can be used with e.g. `PhysicsServer3D.body_get_shape`. The `CollisionObject3D` node keeps a separate organization of shapes per shape owner (the internal...

For this purpose (changing `position` or `global_position` in code and expecting physics bodies to react normally to it) you should use `AnimatableBody2D` instead of `StaticBody2D` or `CharacterBody2D`. I guess the...