python-semanticversion icon indicating copy to clipboard operation
python-semanticversion copied to clipboard
verified publisher icon rbarrois

Improve NpmSpec parsing

Open gnattishness opened this issue 4 years ago • 4 comments

Makes NpmSpec more closely match the node-semver implementation in what syntax it accepts as valid.

Resolves #115

gnattishness avatar Jul 10 '21 07:07 gnattishness

I've left all the commits separate, but I'll squash them once you're happy with the review. Thanks for your time!

gnattishness avatar Jul 10 '21 07:07 gnattishness

I also noticed that NpmSpec would probably accept v>0.1.2 as valid. I get that v isn't part of semver, but not sure if >v0.1.2 is preferred or neither. Happy to add something about this in, if you have any thoughts.

gnattishness avatar Jul 10 '21 07:07 gnattishness

What is missing here? The conflict is only in the changelog and needs to be resolved before merge anyway.

pgampe avatar Mar 09 '23 09:03 pgampe

@pgampe Refer to the linked issue. The maintainer is waiting on clarification from the NPM semver implementers. If you'd like action here, I'd be happy for any progress in pushing for an answer from the NPM folks :)

gnattishness avatar May 02 '23 06:05 gnattishness