guardian icon indicating copy to clipboard operation
guardian copied to clipboard

feat: allow appeal for other user configurable in policy

Open singhvikash11 opened this issue 3 years ago • 1 comments

Implement https://github.com/odpf/guardian/issues/212: Appeal request on behalf of another user

singhvikash11 avatar Aug 03 '22 12:08 singhvikash11

Pull Request Test Coverage Report for Build 3058135432

  • 19 of 33 (57.58%) changed or added relevant lines in 2 files are covered.
  • 151 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+2.7%) to 76.286%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 18 32 56.25%
<!-- Total: 19 33
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/grpc.go 1 91.3%
internal/store/postgres/approval_repository.go 3 92.86%
core/appeal/service.go 70 78.4%
api/handler/v1beta1/adapter.go 77 80.28%
<!-- Total: 151
Totals Coverage Status
Change from base Build 2945876610: 2.7%
Covered Lines: 5842
Relevant Lines: 7658

💛 - Coveralls

coveralls avatar Aug 03 '22 12:08 coveralls