firehose icon indicating copy to clipboard operation
firehose copied to clipboard

make protoc plugin compatiable for M1 chip & fix some tc

Open stym06 opened this issue 2 years ago • 0 comments

This fixes the Gradle build failures when running on M1 chipset

I added a condition to check for OS type and downloads the jar for osx-x86_64 as that still works for M1. If we don't do this, Gradle tries to download the jar osx-aarch_64 which is not available for distribution. Ref: https://github.com/grpc/grpc-java/issues/7690

:heavy_check_mark: Checklist

  • [x] Updated build.gradle for protoc and protoc-gen-grpc-java correct versions
  • [x] Fixed dependency conflict for snappy-java
  • [x] Fixed test cases on src/test/java/io/odpf/firehose/serializer/MessageToJsonTest.java that missed a comma in the assertion while comparing timestamp. (Mar 20, 2017, 10:54:00 AM) Missed a comma after 2017
  • [x] Updated gRPC test files mentioned port from 5000 to 5050 because macOS 13 has port 5000 used by Control Center (link)

stym06 avatar Feb 27 '23 06:02 stym06