compass
compass copied to clipboard
raystack
feat: include latest probe in lineage response
- Return node attributes in Lineage response for GetGraph call. Node attributes include latest probe for asset nodes in the Graph. This enables showing live lineage.
- Use context for gRPC dial and compass service handler in server.
- Add support for fetching probes with filters from asset repository.
Supported filters:
- AssetURNs - zero or more asset URNs.
- MaxRows - Number of rows for each Asset URN ordered by latest first.
- OlderThan,NewerThan - Data range.
- Fix some lint errors.
Should be merged after #178 (would be rebased on main)
Pull Request Test Coverage Report for Build 3334522429
- 95 of 103 (92.23%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.09%) to 86.176%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/server/v1beta1/lineage.go | 19 | 23 | 82.61% |
| internal/store/postgres/asset_repository.go | 31 | 35 | 88.57% |
| <!-- | Total: | 95 | 103 |
| Totals | |
|---|---|
| Change from base Build 3334502082: | 0.09% |
| Covered Lines: | 4962 |
| Relevant Lines: | 5758 |
💛 - Coveralls
LGTM, but found an issue that may or may not be solved in this PR https://github.com/odpf/compass/issues/182
It is out of scope for sure, but can this be easily solved in this PR? @sudo-suhas
Created a different PR to fix that issue - https://github.com/odpf/compass/pull/183
This way git history is cleaner and we are not including unrelated change in this PR.