feat: allow feature_table as an asset type

Open sudo-suhas opened this issue 3 years ago • 3 comments

Related to https://github.com/odpf/meteor/pull/417

Oct 06 '22 09:10 sudo-suhas

Pull Request Test Coverage Report for Build 3262550248

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.115%

Totals
Change from base Build 3225140857:	0.0%
Covered Lines:	4887
Relevant Lines:	5675

💛 - Coveralls

Oct 06 '22 11:10 coveralls

LGTM, just a small concern if ml_feature_table is a good type name? cc: @sudo-suhas @ravisuhag

Oct 11 '22 06:10 StewartJingga

Do you have a suggestion @StewartJingga? In the PR for adding E2E lineage entities (https://github.com/odpf/proton/pull/193), we had discussed calling it FeatureTable instead of MLFeatureTable but chose to keep it as MLFeatureTable because 'Feature' is an overloaded word that is not clear enough.

Oct 11 '22 07:10 sudo-suhas