ray icon indicating copy to clipboard operation
ray copied to clipboard

Add generic item support for queue

Open haarisr opened this issue 1 year ago • 2 comments

Why are these changes needed?

Add generic support for queue. This allows the queue to be templated over any type allowing for type checkers to work better.

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [x] This PR is not tested :(

haarisr avatar Jul 29 '24 18:07 haarisr

also there are some unit tests failures

rkooo567 avatar Aug 26 '24 17:08 rkooo567

The error has something to do with the docs not building.

Unfortunately I'm not super familiar with readthedocs, it's something to do with generic types.

ray/python/ray/util/queue.py:docstring of ray.util.queue.Queue:1: WARNING: py:obj reference target not found: ray.util.queue.T

haarisr avatar Aug 27 '24 05:08 haarisr

can you first try adding a unit test? If it still fails, I can help resolving this

rkooo567 avatar Aug 28 '24 20:08 rkooo567

can you first try adding a unit test? If it still fails, I can help resolving this

Hi bumping this

haarisr avatar Sep 26 '24 17:09 haarisr

This pull request has been automatically marked as stale because it has not had any activity for 14 days. It will be closed in another 14 days if no further activity occurs. Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

github-actions[bot] avatar Jun 18 '25 00:06 github-actions[bot]

stale; @haarisr please re-open if you are still interested in contributing this!

edoakes avatar Jul 08 '25 17:07 edoakes