ray icon indicating copy to clipboard operation
ray copied to clipboard

[core] Delete gcs heartbeat manager

Open fishbone opened this issue 3 years ago • 2 comments

Why are these changes needed?

The pull-based health check has been running for a month and no significant issue. This PR delete the old code to keep the codebase clean.

We'll maintain the new ones in the future.

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

fishbone avatar Dec 07 '22 20:12 fishbone

LGTM minus test failures

ericl avatar Dec 22 '22 20:12 ericl

let me fix the test.

fishbone avatar Jan 03 '23 22:01 fishbone

@ericl another look?

fishbone avatar Jan 05 '23 23:01 fishbone