ray icon indicating copy to clipboard operation
ray copied to clipboard

[release] Handle exceptions on requests failure when retrieving wheel

Open rickyyx opened this issue 3 years ago • 2 comments

Signed-off-by: rickyyx [email protected]

Why are these changes needed?

Exceptions currently not caught when getting wheel URL, causing tests to fail

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [X] This PR is not tested :(

rickyyx avatar Sep 22 '22 00:09 rickyyx

Any thoughts on testing? I could trigger a release tests to make sure it doesn't break anything

rickyyx avatar Sep 22 '22 00:09 rickyyx

Any thoughts on testing?

Good thinking, alternatively you can try trigger a release test pointing to a non-existent host like wheel_url = "localhost:1234..." which will for sure throw

simon-mo avatar Sep 22 '22 00:09 simon-mo