kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard
verified publisher icon ray-project

[Feature] Why doesn’t serveConfigV2 support file inputs

Open Ethan-rookie opened this issue 5 months ago • 4 comments

Search before asking

  • [x] I had searched in the issues and found no similar feature requirement.

Description

Could someone explain the design decision behind this limitation? thanks

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Ethan-rookie avatar Nov 28 '25 02:11 Ethan-rookie

  1. what do you mean file inputs? can you give an example?

Future-Outlier avatar Nov 29 '25 01:11 Future-Outlier

spec: serveConfigV2: application.yaml like this

Ethan-rookie avatar Dec 01 '25 02:12 Ethan-rookie

RayService’s serveConfigV2 currently only accepts inline YAML strings, for the following reasons:

  • In the CRD, serveConfigV2 is defined as a string, which means it is designed to contain the full YAML content directly. https://github.com/ray-project/kuberay/blob/aa8d8301ce0526f07d03691a3edd64b7d7c07bd1/ray-operator/apis/ray/v1/rayservice_types.go#L105-L109

  • The controller simply treats this string as YAML and unmarshals it.

https://github.com/ray-project/kuberay/blob/aa8d8301ce0526f07d03691a3edd64b7d7c07bd1/ray-operator/controllers/ray/rayservice_controller.go#L1233-L1240

To support file-based inputs, maybe we can add a serveConfigV2From field to load the YAML from a referenced ConfigMap.

win5923 avatar Dec 07 '25 17:12 win5923

this is worth discussing, will put it in my topic to committers next time we have meeting, thank you @win5923

Future-Outlier avatar Dec 08 '25 04:12 Future-Outlier