ravahn
ACT no longer ending combat
There's been a large number of reports in the ACT ffxiv discord starting somewhere around 6.1 saying that combat is no longer ending. I have at least one confirmed person who said that they never clicked the OverlayPlugin "end combat on wipe / out of combat" checkboxes and was solely depending on the ACT encounter timings to end combat. There hasn't been an ACT release in that time, so it seems most likely to be an ffxiv plugin change?
My suspicion is that there is some line flagged by the ffxiv plugin that looks to ACT like combat is continuing even when it is not, and this changed somewhere around the intl 6.1 release changes. I don't have any idea how to debug which lines are causing this, if this is the issue.
ACT's timeout based encounter ending relies upon SetEncounter() being called by the parsing plugin. It's hard from the outside to know what is calling SetEncounter(). Possibly a plugin could check if LastHostileTime updates on each log line parsed to determine if SetEncounter() was called. But during normal combat, this would be most log lines... so you'd have to filter time by when you think the encounter should have ended.
It's an annoying thing for anyone to debug, including Ravahn. We should possibly ask for log contributions where the player knows it is not working properly.
