RFC6455 icon indicating copy to clipboard operation
RFC6455 copied to clipboard

Replace Guzzle based request/response object with PSR-17 factory

Open taavit opened this issue 6 years ago • 5 comments

Current implementation is based on Guzzle PSR-7 implementation. This might lead to have multiple PSR-7 implementation across project (I'm using zend-diactoros in my project). While this is not a big problem, using one implementation across whole project (including libraries) and single request/response factory should make dependency tree smaller.

taavit avatar Oct 16 '19 21:10 taavit

Awesome, I like it! Could you rebase against master please?

cboden avatar May 14 '20 13:05 cboden

Tests failed due to tested php versions. (guzzle requires php ^7.2, nyholm/psr7 ^7.1, diactoros ^7.1) I could switch to laminas/nyholm factories, so this should pass 7.1 as well.

taavit avatar May 14 '20 19:05 taavit

Are there no factory implementations that support older versions?

cboden avatar May 15 '20 11:05 cboden

psr/http-factory itself requires php 7.0+. For php 7.0 I found only this: https://packagist.org/packages/php-extended/php-http-message-factory-psr17

taavit avatar May 15 '20 15:05 taavit

Ok. We're likely doing one more release then dropping support for PHP5 and lower versions of 7. I'll circle back to this PR shortly.

cboden avatar May 15 '20 15:05 cboden