Pawl icon indicating copy to clipboard operation
Pawl copied to clipboard

PHP 8.4 compatibility issues

Open stonie1989 opened this issue 1 year ago • 7 comments

Are there plans to make Pawl fully compatible to PHP 8.4? Currently there are some deprecation warnings regarding the Client connect() function.

Deprecated: Ratchet\Client\connect(): Implicitly marking parameter $loop as nullable is deprecated, the explicit nullable type must be used instead in vendor/ratchet/pawl/src/functions.php on line 12 PHP Deprecated: Ratchet\Client\connect(): Implicitly marking parameter $loop as nullable is deprecated, the explicit nullable type must be used instead in vendor/ratchet/pawl/src/functions.php on line 12

Edit: Would be a very simple change in one line:

From

function connect($url, array $subProtocols = [], $headers = [], LoopInterface $loop = null) {
    $connector = new Connector($loop);
    $connection = $connector($url, $subProtocols, $headers);

    return $connection;
}

To:

function connect($url, array $subProtocols = [], $headers = [], LoopInterface|null $loop = null) {
    $connector = new Connector($loop);
    $connection = $connector($url, $subProtocols, $headers);

    return $connection;
}

stonie1989 avatar Dec 13 '24 15:12 stonie1989

I have a pull request to fix this.

e: later noticed there was already a PR for this issue

taylorvance avatar Dec 17 '24 21:12 taylorvance

I am facing the same issue. When are you planning to give fix for this?

ZalakNHirani avatar Jan 07 '25 12:01 ZalakNHirani

Is this repo even alive?

shehi avatar Jan 08 '25 13:01 shehi

repository hasn't been updated for many years. Is there a chance to fix these errors with php 8.4?

misqkrk avatar Feb 26 '25 20:02 misqkrk

Please, fix this.

andrey-tech avatar Mar 14 '25 09:03 andrey-tech

Could you fix it?

baltun avatar Mar 18 '25 21:03 baltun

This has already been fixed: https://github.com/ratchetphp/Pawl/pull/158

I suspect this could be closed

whoisninjaturtle avatar Jul 17 '25 18:07 whoisninjaturtle