userland icon indicating copy to clipboard operation
userland copied to clipboard

Remove debug-related code from vc_image_structs.h

Open torralbaa opened this issue 4 years ago • 4 comments

The removed lines currently cause the compilation of programs that depend on vc_image_structs.h to fail, since helpers/debug_utils/debug_writer.h does not exist, nor do the DEBUG_* types.

torralbaa avatar Apr 25 '21 17:04 torralbaa

@6by9 looks like one of your commits - do we use this?

popcornmix avatar Apr 26 '21 10:04 popcornmix

vc_image_structs.h was broken out so that it could be used from userland without needing the full vc_image stuff.

vcdbg is the most likely candidate to be using it, but I thought your magic scripts only picked up files that are actually used by the build. I'm surprised we need almost any of these vc_image headers for the public userland repo.

6by9 avatar Apr 26 '21 13:04 6by9

rm -rf helpers/vc_image and ./buildme runs quite happily. Likewise vcinclude/vc_image_types.h appears unused.

(helpers/v3d/v3d_common.h appears unused too)

6by9 avatar Apr 26 '21 14:04 6by9

Hello,

This file seems to be unused by the userland itself, but some programs depend on it. I came here from a forum post by @6by9, and while it's stated that the program shouldn't be used as a "good example", I thought removing the "bad" lines here would be useful.

torralbaa avatar Apr 26 '21 18:04 torralbaa