picotool icon indicating copy to clipboard operation
picotool copied to clipboard

Don't write more data than will fit in flash

Open lurch opened this issue 5 years ago • 7 comments

lurch avatar Apr 01 '21 14:04 lurch

closing this - as the code s pretty stale... the verify option is a good workaround for this anyway, but feel free to re-open an issue

kilograham avatar Oct 05 '21 22:10 kilograham

ha i just got bitten by this myself :-)

kilograham avatar Oct 30 '21 21:10 kilograham

I've just rebased this onto the latest develop. (but I haven't re-tested it)

lurch avatar Oct 31 '21 15:10 lurch

Should I re-open this against master, or just leave it closed?

lurch avatar Nov 01 '21 23:11 lurch

well reopen against develop

kilograham avatar Nov 02 '21 03:11 kilograham

Ahhh, I saw the "kilograham deleted the branch raspberrypi:develop yesterday" message (and I assume that is what auto-closed this PR?), but I didn't realise that you'd actually created a new develop branch.

I don't have the permissions to re-open this PR, so I guess you could either do that for me, or I could create a fresh PR? (which would mean we'd lose your review-comments) - up to you.

lurch avatar Nov 03 '21 00:11 lurch

BTW it's just occurred to me that if you made develop a protected branch, then GitHub probably wouldn't try auto-deleting it each time you merge develop into master? :slightly_smiling_face: (and therefore any other PRs against develop hopefully won't get auto-closed)

lurch avatar Nov 05 '21 01:11 lurch