linux icon indicating copy to clipboard operation
linux copied to clipboard

sound: soc: bcm: Added Sound card driver for Dacberry400 Audio card f…

Open AshishVara opened this issue 3 years ago • 1 comments

…or Raspberry Pi 400

Added Sound card driver for DACberry400 Audio card. Added overlays file and support in menuconfig.

Signed-off-by: Ashish Vara [email protected]

AshishVara avatar Aug 14 '22 19:08 AshishVara

@pelwell , I have fixed review comments and updated PR.

AshishVara avatar Aug 16 '22 18:08 AshishVara

That's much better. If you can make three more changes I'll merge it:

  1. The additions to the _defconfig files are correct but not on the expected lines. For each of those files, run "make ARCH=arm savedefconfig" (or arm64) which will create a file called "defconfig". Copy that over the _defconfig in arch/... .
  2. There are 4 lines which are made very long because of trailing comments. Put the comments on the lines above if you must have them.
  3. Split the changes into three separate commits:
    • one for the driver, Kconfig and Makefile (the changes in sound/soc/bcm) - use this commit message
    • one for the defconfig changes ("configs: Enable DACBERRY400")
    • one for the overlay ("overlays: Add dacberry400").

pelwell avatar Aug 17 '22 19:08 pelwell

Those look good - just the defconfig commit now.

pelwell avatar Aug 22 '22 08:08 pelwell

@pelwell , Pushed defconfig commit. Please check.

AshishVara avatar Aug 22 '22 08:08 AshishVara

Any reason this couldn't have been done with a simple/graph sound card DT overlay?

nullr0ute avatar Aug 23 '22 18:08 nullr0ute

Give me a PR with equivalent functionality and I'll use it instead.

pelwell avatar Aug 23 '22 18:08 pelwell